Memoized helper methods instead of instance variables in controllers

pdbradley · March 22, 2016, 11:38am

This is sort of a personal question to @sgrif but might be of general interest so I’m posting it here. I recently discovered the Bikeshed podcast and have been going through the episodes (starting with number 1). On at least two separate episodes Sean has said rather contentedly that he doesn’t like to pass instance variables to views, he prefers to use memoized helper methods. I know what memoized means and I know what helper methods are, but I’m not sure where you would put those methods, or how they would look.

Anyway I’d love to see an example of what you are talking about because I agree with the general philosophy of what you are saying.

I love the podcast.

davidcpell · March 22, 2016, 2:39pm

Here’s a gist that gives an example of using memoized helper methods in a controller:

gist.github.com

https://gist.github.com/bloudermilk/8345597

memoized-helper-methods.md

Last year I started playing around with using memoized private helper methods in my controllers instead of the traditional instance variable assigns we see in RoR controllers. Here's an example:

```ruby
class PostsController < ApplicationController
  helper_method :new_post, :post, :posts
  
  def new; end
  def show; end
  def edit; end
  def index; end

This file has been truncated. show original

It turns out ActionController has a helper_method class method that makes methods available in the views as if they were defined in an actual helper module:
http://apidock.com/rails/ActionController/Helpers/ClassMethods/helper_method

You can memoize the results of private methods in the controller and then make those methods available to the view as helper methods.

pdbradley · March 22, 2016, 5:01pm

That’s super helpful @davidcpell, thanks!

andyw8 · March 22, 2016, 7:17pm

I agree with avoiding instance variables in views.

I tried the memoized variables approach for a while, but I’ve come to prefer explicit render calls instead. Here’s an example:

gist.github.com

https://gist.github.com/andyw8/f765fcf47244d25d0dce

renders.rb

class WidgetsController < ApplicationController
  def index
    render 'index', locals: { widgets: scoped_widgets }
  end

  def show
    render 'show', locals: { widget: find_widget }
  end

  def new

This file has been truncated. show original

Topic		Replies	Views
Overuse of Instance Variables in Controllers? Ruby on Rails	3	2470	January 5, 2015
Helper methods and ApplicationController Intro Rails Tutorial	2	1797	September 9, 2013
Single instance variables in controllers Intermediate Rails Tutorial	3	1303	January 18, 2014
Instance vs local variables in controller method when they wont be used by a view Intro Rails Tutorial	4	1291	May 14, 2013
Refactoring the controller instance variable finds Ruby on Rails	2	653	March 13, 2014

Memoized helper methods instead of instance variables in controllers

Related topics