← Back to Upcase

Learn visual refresh


(Ben Orenstein) #1

@Phil_LaPier pushed a very nice set of style changes to Learn yesterday. I think the site looks a heck of a lot better.

How do things look to you all?

Notice anything that seems off? Let us know and we’ll take care of it.


(Jared Smith) #2

On the sign in page the sign in button looks funky on iPad / iPhones.

It looks like you’re missing this style.

input[type="submit"] {
    -webkit-appearance: none;
}

it overrides safari’s inclination to trump your styling on that element.


(Ben Orenstein) #3

Thanks for the report and the fix!

I can make that change myself or, if you like, you can submit a pull request on the Learn repo. Not trying to push work off on you, but some folks like contributing.

Let me know!


(Jared Smith) #4

Sure thing I will submit a pull request. :smile:

I’m pretty new to contributing. So would be nice to do more of it. I just wanted to post something here so other learn subscribers could see.